Pulse gates: assembly changes#4969
Merged
Merged
Conversation
…ature: pulse library may appear at the top level qasm job config, and each experiment config may have a list of gate calibrations. Break out assembling pulse gates into its own private function Add support for parametric pulses
taalexander
previously requested changes
Aug 24, 2020
…ings, more careful about importing private function
Contributor
Author
|
great feedback, thank you @blakejohnson and @taalexander . I've updated in response |
blakejohnson
previously approved these changes
Aug 27, 2020
Contributor
blakejohnson
left a comment
blakejohnson
left a comment
There was a problem hiding this comment.
One stylistic nit, but otherwise I am good.
taalexander
previously approved these changes
Aug 27, 2020
Contributor
taalexander
left a comment
taalexander
left a comment
There was a problem hiding this comment.
All comments are minor.
taalexander
approved these changes
Aug 27, 2020
lcapelluto
added
automerge
Changelog: Added
taalexander
removed
the
Changelog: Added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add piece for assembling front end to the defined qobj schema
Follow up to #4859
Details and comments
TODO